[To metric branch] Add benchmarks for targeting Exemplar impact #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Feb 17, 2023
| | Method | EnableExemplar | Mean | Error | StdDev | Allocated | | ||
| |---------------- |--------------- |---------:|--------:|--------:|----------:| | ||
| | HistogramUpdate | False | 249.6 ns | 4.42 ns | 7.13 ns | - | | ||
| | HistogramUpdate | True | 284.2 ns | 5.39 ns | 5.04 ns | - | |
There was a problem hiding this comment.
this does not use the spec prescribed API for Reservoir. THe spec mandated one does not allow passing the histogram index, so it'd require finding the histogram index twice (this is how java implemented it now).
Will try that and share numbers as well for ref.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main-metrics #4203 +/- ##
================================================
+ Coverage 84.73% 84.80% +0.06%
================================================
Files 296 296
Lines 11529 11529
================================================
+ Hits 9769 9777 +8
+ Misses 1760 1752 -8
|
cijothomas
changed the title
reyang
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes